http://codereview.chromium.org/15079/diff/401/601 File src/register-allocator-ia32.cc (right):
http://codereview.chromium.org/15079/diff/401/601#newcode95 Line 95: } On 2008/12/22 13:55:21, William Hesse wrote: > I think we are missing the case where this.reg() is target, > but target occurs multiple times in the frame. We need to spill target in that > case, I think. Yes, according to the comment in the header we do. Fixed. We still need to handle the case that the target register is multiply referenced outside the frame (or otherwise unallocatable, which amounts to the same thing). http://codereview.chromium.org/15079/diff/401/601#newcode109 Line 109: Use(edi); On 2008/12/22 13:55:21, William Hesse wrote: > Aren't we going to need to unuse edi before the ValidRegisters check at > JumpTarget works? > We can't jump before Enter is called on the frame. That seems reasonable. http://codereview.chromium.org/15079/diff/401/607 File src/register-allocator-ia32.h (right): http://codereview.chromium.org/15079/diff/401/607#newcode100 Line 100: // it. On 2008/12/22 13:55:21, William Hesse wrote: > How can we move a result into a register that isn't spilled? Are you referring > to the case that the result is already in a register? Then it isn't being > moved. Otherwise, aren't we messing up the value already in the register? Yes, the comment refers to the case where the result is in a register. In that case, the current register is as arbitrary as any other. http://codereview.chromium.org/15079 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
