LGTM, with comments.
http://codereview.chromium.org/16536/diff/401/8 File src/codegen-ia32.cc (right): http://codereview.chromium.org/16536/diff/401/8#newcode2626 Line 2626: __ mov(temp.reg(), SlotOperand(slot, temp.reg())); This was __mov(eax, SlotOperand(slot, ecx)). What is ecx, and why has it been replaced by temp.reg()? Isn't it something different than eax? http://codereview.chromium.org/16536/diff/401/8#newcode2645 Line 2645: __ mov(temp.reg(), SlotOperand(slot, temp.reg())); Same here, second arg of SlotOperand() was ecx. http://codereview.chromium.org/16536/diff/401/8#newcode2696 Line 2696: __ mov(temp.reg(), SlotOperand(slot, temp.reg())); Same, ecx versus eax. http://codereview.chromium.org/16536 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
