LGTM!
http://codereview.chromium.org/16538/diff/206/209 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/16538/diff/206/209#newcode69 Line 69: * - register n ebp[-4*(n+1)] I would prefer n - 1 here which would correspond to num_registers. http://codereview.chromium.org/16538/diff/206/209#newcode71 Line 71: * pointer to the stack being used). I think defining kSystemStackPseudoStackPage to zero would make things clearer here and other places. http://codereview.chromium.org/16538/diff/206/209#newcode104 Line 104: * | stack-limit = stack-bottom + 1KB not always 1kbyte I prefer not to abbreviate byte. For 1024 I prefer either Ki which is correct or k which is correct for 1000. K seems neither fish nor fowl. http://codereview.chromium.org/16538/diff/206/209#newcode640 Line 640: __ enter(Immediate((num_registers_ + 1) * kPointerSize)); The + 1 needs a comment. http://codereview.chromium.org/16538/diff/206/209#newcode754 Line 754: __ pop(esp); // This might switch to another stack area! Please add comment explaining to reader the circumstances under which it would switch. http://codereview.chromium.org/16538 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
