LGTM
http://codereview.chromium.org/17354/diff/203/8 File src/apinatives.js (right): http://codereview.chromium.org/17354/diff/203/8#newcode67 Line 67: (serialNumber in kApiFunctionCache) && Use the local variable 'cache' throughout this function? http://codereview.chromium.org/17354/diff/203/8#newcode68 Line 68: (kApiFunctionCache[serialNumber] != -1); How about introducing a named constants in macros.py for the -1? http://codereview.chromium.org/17354 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
