http://codereview.chromium.org/17354/diff/203/8
File src/apinatives.js (right):

http://codereview.chromium.org/17354/diff/203/8#newcode67
Line 67: (serialNumber in kApiFunctionCache) &&
On 2009/01/13 07:00:39, Mads Ager wrote:
> Use the local variable 'cache' throughout this function?

Fixed

http://codereview.chromium.org/17354/diff/203/8#newcode68
Line 68: (kApiFunctionCache[serialNumber] != -1);
On 2009/01/13 07:00:39, Mads Ager wrote:
> How about introducing a named constants in macros.py for the -1?

I would, but I wouldn't be able to look it up in the exception handler,
so there's not much use for it.

http://codereview.chromium.org/17354

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to