Sticks the value!
http://codereview.chromium.org/18193/diff/1/6 File src/flag-definitions.h (right): http://codereview.chromium.org/18193/diff/1/6#newcode202 Line 202: // Irregexp What about the failing layout tests? http://codereview.chromium.org/18193/diff/1/14 File src/jsregexp.cc (left): http://codereview.chromium.org/18193/diff/1/14#oldcode4099 Line 4099: RegExpNode* ActionNode::PropagateForward(NodeInfo* info) { O joy, we can get rid of all this cra..., I mean stuff. http://codereview.chromium.org/18193/diff/1/14 File src/jsregexp.cc (right): http://codereview.chromium.org/18193/diff/1/14#newcode2379 Line 2379: assembler->LoadCurrentCharacter(-1, new_trace.backtrack(), false); Maybe a comment about why this works when you're at character 0? http://codereview.chromium.org/18193/diff/1/14#newcode2391 Line 2391: Label before_non_word; Maybe you could split these huge cases out into separate functions, that way you could just pass different arguments for the boundary and non-boundary cases. http://codereview.chromium.org/18193/diff/1/14#newcode2419 Line 2419: assembler->LoadCurrentCharacter(new_trace.cp_offset() - 1, What happens here if we're right at the beginning of the input? http://codereview.chromium.org/18193/diff/1/14#newcode2655 Line 2655: // We can call this with by == 0. In that case it just means that the Maybe split invalidation out into a separate method? I was really confused by the AdvanceCurrentPositionInTrace(0, ...) in EmitWordCheck. http://codereview.chromium.org/18193/diff/1/14#newcode3865 Line 3865: new RegExpCharacterClass(newline_ranges, false); You should be able to just use "new RegExpCharacterClass('n')". http://codereview.chromium.org/18193/diff/1/14#newcode3868 Line 3868: TextNode* newline_matcher = new TextNode( You should be able to use "new TextNode(newline_atom, ...)". http://codereview.chromium.org/18193/diff/1/14#newcode3885 Line 3885: UNREACHABLE(); Maybe have this in the 'default' case, that way the compiler will complain if we forget the return in one of the other cases. http://codereview.chromium.org/18193/diff/1/2 File test/mozilla/mozilla.status (left): http://codereview.chromium.org/18193/diff/1/2#oldcode231 Line 231: I wouldn't enable us by default yet, and so I wouldn't reenable these tests either. http://codereview.chromium.org/18193 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
