Reviewers: Christian Plesner Hansen,

Description:
Changes to the V8 debugger support which otherwise caused problems with
Chrome.

Added quoting of the name of the ref property using {"ref":1} instead of
{ref:1}. The Chrome C++ JSON parser implementation requires quoted
property names.

Changed the JSON format for non finite numbers. The previous formatting
using NaN, Infinite and -Infinite caused the Chrome C++ JSON parser
implementation to fail. Values "NaN", "Infinite" and "-Infinite"
(incuding quotes) are now used.

Reverted changes to DebugLookupResultValue (runtime.cc) from
http://codereview.chromium.org/17377. The change caused callback into
Chrome with the current V8 context expected to have a DOM Window global
object. This is not the case when the debugger context is the active
context. This causes properties from interceptors and accessors to be
reported as undefined in the debugger.

Please review this at http://codereview.chromium.org/18194

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/mirror-delay.js
   M     src/runtime.cc
   M     test/cctest/test-debug.cc
   M     test/mjsunit/mirror-object.js



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to