http://codereview.chromium.org/18497/diff/1/2
File src/ast.cc (right):

http://codereview.chromium.org/18497/diff/1/2#newcode264
Line 264: }
That's pretty obscure but I've added it anyway.

The same thing holds for the term following an initial  assertion but
that's not worth the trouble to implement.

http://codereview.chromium.org/18497/diff/1/2#newcode439
Line 439: : alternatives_(alternatives) {
Added

http://codereview.chromium.org/18497/diff/1/2#newcode453
Line 453: ASSERT(nodes->length() > 0);
Fixed

http://codereview.chromium.org/18497/diff/1/5
File test/mjsunit/ascii-regexp-subject.js (right):

http://codereview.chromium.org/18497/diff/1/5#newcode31
Line 31:
It is indeed more like a benchmark but I'll leave it to Erik to create
that.  I'm keeping the test because something, even if it's pretty poor,
is better than nothing.  Also, our friend the arm simulator makes this
test falsifiable on the build bot.

http://codereview.chromium.org/18497

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to