LGTM
http://codereview.chromium.org/18497/diff/1/2 File src/ast.cc (right): http://codereview.chromium.org/18497/diff/1/2#newcode248 Line 248: return type() == RegExpAssertion::START_OF_INPUT; Hey, if you're adding obscure cases then this should return true if the successor returns true. http://codereview.chromium.org/18497/diff/1/5 File test/mjsunit/ascii-regexp-subject.js (right): http://codereview.chromium.org/18497/diff/1/5#newcode31 Line 31: On 2009/01/22 15:29:52, Lasse Reichstein wrote: > Is this "test" falsifiable? Sure it's falsifiable. That's how we found this bug :-) http://codereview.chromium.org/18497 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
