LGTM
http://codereview.chromium.org/18587/diff/1/6 File src/jsregexp.cc (right): http://codereview.chromium.org/18587/diff/1/6#newcode1279 Line 1279: while (!work_list.is_empty()) { You could bail out of this loop if the regexp is too big (i.e., work list is mepty or reg_exp_too_big_ is true). http://codereview.chromium.org/18587/diff/1/6#newcode1483 Line 1483: return; The return is superfluous. http://codereview.chromium.org/18587/diff/1/2 File src/regexp-macro-assembler.h (right): http://codereview.chromium.org/18587/diff/1/2#newcode41 Line 41: // The implmentation must be able to handle at least: Typo "implementation". I agree that any regexp failing these offsets is a pathological case, and they are acceptable to the ia32-version (2^16 registers should fit on the system stack). http://codereview.chromium.org/18587 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
