http://codereview.chromium.org/18587/diff/1/6
File src/jsregexp.cc (right):

http://codereview.chromium.org/18587/diff/1/6#newcode1279
Line 1279: while (!work_list.is_empty()) {
On 2009/01/26 13:48:53, Lasse Reichstein wrote:
> You could bail out of this loop if the regexp is too big (i.e., work
list is
> mepty or reg_exp_too_big_ is true).

Unfortunately I can't because there are labels that are linked but won't
get bound in this case.  There's an assert in debug mode that will
trigger in this case.

http://codereview.chromium.org/18587/diff/1/6#newcode1483
Line 1483: return;
On 2009/01/26 13:48:53, Lasse Reichstein wrote:
> The return is superfluous.

I don't think so!

http://codereview.chromium.org/18587

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to