LGTM, except some requested changes to comments.
http://codereview.chromium.org/18596/diff/610/611 File src/codegen-ia32.cc (right): http://codereview.chromium.org/18596/diff/610/611#newcode3734 Line 3734: // VirtualFrame::SpilledScope spilled_scope(this); Get rid of this commented code. http://codereview.chromium.org/18596/diff/610/611#newcode4682 Line 4682: // The arguments to the functions are on top of the frame. I find this comment more confusing than clarifying. I'm not sure there needs to be a comment at all. Anyway, there are not functions, there is only one; and it's not exactly a function but an IC stub. http://codereview.chromium.org/18596/diff/610/611#newcode4762 Line 4762: // Free the registers used by the call. This comment doesn't entirely make sense. http://codereview.chromium.org/18596 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
