http://codereview.chromium.org/18596/diff/610/611
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18596/diff/610/611#newcode3734
Line 3734: //  VirtualFrame::SpilledScope spilled_scope(this);
On 2009/01/30 09:26:10, Kevin Millikin wrote:
> Get rid of this commented code.

Done.

http://codereview.chromium.org/18596/diff/610/611#newcode4682
Line 4682: // The arguments to the functions are on top of the frame.
On 2009/01/30 09:26:10, Kevin Millikin wrote:
> I find this comment more confusing than clarifying.  I'm not sure
there needs to
> be a comment at all.  Anyway, there are not functions, there is only
one; and
> it's not exactly a function but an IC stub.

Done.

http://codereview.chromium.org/18596/diff/610/611#newcode4762
Line 4762: // Free the registers used by the call.
On 2009/01/30 09:26:10, Kevin Millikin wrote:
> This comment doesn't entirely make sense.

Done.

http://codereview.chromium.org/18596

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to