LGTM
http://codereview.chromium.org/21403/diff/31/32 File src/log.cc (right): http://codereview.chromium.org/21403/diff/31/32#newcode866 Line 866: fprintf(logfile_, ",0x%x", (unsigned int)(sample->stack[i])); Please use reinterpret_cast<unsigned int>(...). http://codereview.chromium.org/21403/diff/31/32#newcode960 Line 960: ticker_ = new Ticker(10, (unsigned int)&stack_var); Please use reinterpret_cast<unsigned int>(...). http://codereview.chromium.org/21403 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
