On Tue, Feb 17, 2009 at 3:31 PM, Søren Gjesse <[email protected]> wrote:
> > > On Tue, Feb 17, 2009 at 3:22 PM, <[email protected]> wrote: > >> Submitting... > > > Fantastic! > > >> Do we need to update tickprocessor.py on the CB machines manually? >> > > I am afraid so. Unfortunately it sits in Erik Corry's home dir and he is on > vacation. I will ping him. > Consider me pinged! > > http://codereview.chromium.org/21403/diff/31/32 >> File src/log.cc (right): >> >> http://codereview.chromium.org/21403/diff/31/32#newcode866 >> Line 866: fprintf(logfile_, ",0x%x", (unsigned int)(sample->stack[i])); >> On 2009/02/17 14:14:50, Søren Gjesse wrote: >> >>> Please use reinterpret_cast<unsigned int>(...). >>> >> >> Done. >> >> http://codereview.chromium.org/21403/diff/31/32#newcode960 >> Line 960: ticker_ = new Ticker(10, (unsigned int)&stack_var); >> On 2009/02/17 14:14:50, Søren Gjesse wrote: >> >>> Please use reinterpret_cast<unsigned int>(...). >>> >> >> Done. >> >> >> http://codereview.chromium.org/21403 >> > > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
