LGTM.
http://codereview.chromium.org/28027/diff/25/26 File src/compilation-cache.h (right): http://codereview.chromium.org/28027/diff/25/26#newcode83 Line 83: // tripple with the boilerplate. This may overwrite an existing tripple -> triple http://codereview.chromium.org/28027/diff/25/27 File src/objects.cc (right): http://codereview.chromium.org/28027/diff/25/27#newcode5955 Line 5955: hash ^= String::cast(script->source())->Hash(); It's not clear that this is a great way of mixing the bits. http://codereview.chromium.org/28027 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
