On 2009/02/24 11:21:08, Kasper Lund wrote: > LGTM. > http://codereview.chromium.org/28027/diff/25/26 > File src/compilation-cache.h (right):
> http://codereview.chromium.org/28027/diff/25/26#newcode83 > Line 83: // tripple with the boilerplate. This may overwrite an existing > tripple -> triple Done. > http://codereview.chromium.org/28027/diff/25/27 > File src/objects.cc (right): > http://codereview.chromium.org/28027/diff/25/27#newcode5955 > Line 5955: hash ^= String::cast(script->source())->Hash(); > It's not clear that this is a great way of mixing the bits. As we discussed, there is no reason to use the source end position as part of the hash. I now xor the string hash codes and add the start position to get the final hash value. http://codereview.chromium.org/28027 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
