http://codereview.chromium.org/28068/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/28068/diff/1/2#newcode6863
Line 6863: set_line_ends(*(Factory::NewArrayLiteral(0)));
Please use NewJSArray.

http://codereview.chromium.org/28068/diff/1/3
File test/cctest/test-compiler.cc (right):

http://codereview.chromium.org/28068/diff/1/3#newcode317
Line 317: CHECK_EQ(-1, script->GetLineNumber(-1));
As this bug originated from Chrome where source is external strings
using an empty external string in the test case as well might be a good
idea.

http://codereview.chromium.org/28068

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to