http://codereview.chromium.org/28068/diff/1/2 File src/objects.cc (right):
http://codereview.chromium.org/28068/diff/1/2#newcode6863 Line 6863: set_line_ends(*(Factory::NewArrayLiteral(0))); On 2009/02/24 13:23:52, Søren Gjesse wrote: > Please use NewJSArray. Um, but 'NewArrayLiteral' uses NewJSArrayWithElements. Isn't it the same? http://codereview.chromium.org/28068/diff/1/3 File test/cctest/test-compiler.cc (right): http://codereview.chromium.org/28068/diff/1/3#newcode317 Line 317: CHECK_EQ(-1, script->GetLineNumber(-1)); On 2009/02/24 13:23:52, Søren Gjesse wrote: > As this bug originated from Chrome where source is external strings using an > empty external string in the test case as well might be a good idea. Ok, will add such test. But it will be a new CL since I already commited this one immediately after your LGTM ;) http://codereview.chromium.org/28068 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
