Does it lint and compile on ARM? LGTM.
http://codereview.chromium.org/28311/diff/1001/1004 File src/jsregexp.cc (right): http://codereview.chromium.org/28311/diff/1001/1004#newcode389 Line 389: // Ensures that the regexp object containst a compiled version of the spolling! http://codereview.chromium.org/28311/diff/1001/1004#newcode482 Line 482: int RegExpImpl::IrregexpNumberOfRegisters(Handle<FixedArray> re) { This looks like exactly the same as IrregexpMaxRegisterCount http://codereview.chromium.org/28311/diff/1001/1004#newcode759 Line 759: // TODO(lrn): How do we know the array is long enough. Because we called EnsureSize at all the places where we could call here. You could ASSERT that it is true. http://codereview.chromium.org/28311/diff/1001/1004#newcode774 Line 774: // Implmentation of the Irregexp regular expression engine. Spolling! (Not yours...) http://codereview.chromium.org/28311 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
