Lint: yes.
Compile on ARM: Yes, now. I had actually broken the bytecode matching.


http://codereview.chromium.org/28311/diff/1001/1004
File src/jsregexp.cc (right):

http://codereview.chromium.org/28311/diff/1001/1004#newcode389
Line 389: // Ensures that the regexp object containst a compiled version
of the
On 2009/03/02 12:01:48, Erik Corry wrote:
> spolling!

Done.

http://codereview.chromium.org/28311/diff/1001/1004#newcode482
Line 482: int RegExpImpl::IrregexpNumberOfRegisters(Handle<FixedArray>
re) {
It is. Or it was, not it's gone.

http://codereview.chromium.org/28311/diff/1001/1004#newcode759
Line 759: // TODO(lrn): How do we know the array is long enough.
Done.

http://codereview.chromium.org/28311

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to