LGTM
http://codereview.chromium.org/39009/diff/1001/1002 File src/frames-inl.h (right): http://codereview.chromium.org/39009/diff/1001/1002#newcode187 Line 187: while (true) { while (true) -> while(!done()). http://codereview.chromium.org/39009/diff/1001/1004 File src/frames.h (right): http://codereview.chromium.org/39009/diff/1001/1004#newcode627 Line 627: typedef JavaScriptFrameIteratorTemp<SafeStackFrameIterator> SafeJSFrameIterator; SafeJSFrameIterator -> SafeJavaScriptFrameIterator? http://codereview.chromium.org/39009/diff/1001/1004#newcode629 Line 629: Add #ifdef ENABLE_LOGGING_AND_PROFILING for this class http://codereview.chromium.org/39009/diff/1001/1004#newcode630 Line 630: class SafeStackTraceFrameIterator: public SafeJSFrameIterator { Maybe remove the Safe prefix (there is no unsafe version) http://codereview.chromium.org/39009/diff/1001/1005 File src/log.cc (right): http://codereview.chromium.org/39009/diff/1001/1005#newcode147 Line 147: if (Top::c_entry_fp(Top::GetCurrentThread())) { Please add != NULL http://codereview.chromium.org/39009/diff/1001/1005#newcode153 Line 153: for (; !it.done() && depth <= kMaxStackFrames; ++depth, it.Advance()); Most V8 code uses a while loop for this type of code. http://codereview.chromium.org/39009 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
