http://codereview.chromium.org/39009/diff/1001/1002 File src/frames-inl.h (right):
http://codereview.chromium.org/39009/diff/1001/1002#newcode187 Line 187: while (true) { On 2009/03/03 11:30:11, Søren Gjesse wrote: > while (true) -> while(!done()). Done. http://codereview.chromium.org/39009/diff/1001/1004 File src/frames.h (right): http://codereview.chromium.org/39009/diff/1001/1004#newcode627 Line 627: typedef JavaScriptFrameIteratorTemp<SafeStackFrameIterator> SafeJSFrameIterator; On 2009/03/03 11:30:11, Søren Gjesse wrote: > SafeJSFrameIterator -> SafeJavaScriptFrameIterator? Done. http://codereview.chromium.org/39009/diff/1001/1004#newcode629 Line 629: On 2009/03/03 11:30:11, Søren Gjesse wrote: > Add #ifdef ENABLE_LOGGING_AND_PROFILING for this class Done. http://codereview.chromium.org/39009/diff/1001/1004#newcode630 Line 630: class SafeStackTraceFrameIterator: public SafeJSFrameIterator { On 2009/03/03 11:30:11, Søren Gjesse wrote: > Maybe remove the Safe prefix (there is no unsafe version) Actually, there is one, see above around line 589. I moved it from top.cc to keep related things together. http://codereview.chromium.org/39009/diff/1001/1005 File src/log.cc (right): http://codereview.chromium.org/39009/diff/1001/1005#newcode147 Line 147: if (Top::c_entry_fp(Top::GetCurrentThread())) { On 2009/03/03 11:30:11, Søren Gjesse wrote: > Please add != NULL Done. http://codereview.chromium.org/39009/diff/1001/1005#newcode153 Line 153: for (; !it.done() && depth <= kMaxStackFrames; ++depth, it.Advance()); On 2009/03/03 11:30:11, Søren Gjesse wrote: > Most V8 code uses a while loop for this type of code. Done. http://codereview.chromium.org/39009 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
