2009/3/16 Kasper Lund <[email protected]>: > > Very quick drive-by comment: Isn't there a faster way to iterate over > the elements and properties of the cloned object than using > GetLocalElementKeys and GetLocaPropertyNames? Don't we know that the > boilerplates only have fast properties and dense elements, so two > simple loops over [0, (properties/elements).length) would suffice? > Maybe not...
This makes sense to me. > It also might make sense to rewrite the DeepCopy to use handles... After our abolition of the two-allocations rule in non-handle code there doesn't seem to be a practical problem with doing DeepCopy without handles and I would expect it be faster the way it is. > > 2009/3/16 <[email protected]>: >> >> Reviewers: Erik Corry, >> >> Description: >> Reapply revisions 1432, 1433, 1469 and 1472 while fixing issue 279. >> >> Please review this at http://codereview.chromium.org/48006 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/ast.h >> M src/ast.cc >> M src/codegen-arm.cc >> M src/codegen-ia32.cc >> M src/heap.h >> M src/parser.h >> M src/parser.cc >> M src/runtime.h >> M src/runtime.cc >> M test/mjsunit/fuzz-natives.js >> M test/mjsunit/regress/regress-279.js >> >> >> >> > >> > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
