LGTM I'd like to see the test include a huge nested literal so we can test GC during clone of boilerplate.
The clone operation is recursive. Should we be checking for stack overflow? Are there tests of making sure that nested arrays and objects have the correct context when created? I'm a bit hazy on this part of the VM to be honest, but it seems there is an issue here, but no tests. Otherwise LGTM if it lints, passes tests and works on ARM. http://codereview.chromium.org/48006/diff/1/7 File src/codegen-arm.cc (right): http://codereview.chromium.org/48006/diff/1/7#newcode2637 Line 2637: // If the entry is undefined we call the runtime system to computed spolling (not yours) http://codereview.chromium.org/48006/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/48006/diff/1/5#newcode73 Line 73: // Cast the given object to an int and store it in a variable with Should say smi instead of int in name and comments. http://codereview.chromium.org/48006/diff/1/5#newcode117 Line 117: if (attributes != NONE) continue; I think this line warrants some explanation. http://codereview.chromium.org/48006/diff/1/5#newcode120 Line 120: if (value->IsFailure()) return result; You just asserted this couldn't happen... http://codereview.chromium.org/48006/diff/1/5#newcode140 Line 140: if (value->IsFailure()) return result; ditto http://codereview.chromium.org/48006/diff/1/5#newcode154 Line 154: HandleScope scope; I wonder why we need this. DeepCopyBoilerplate isn't handle-based so it can't call handle code. http://codereview.chromium.org/48006/diff/1/2 File test/mjsunit/regress/regress-279.js (right): http://codereview.chromium.org/48006/diff/1/2#newcode62 Line 62: assertEquals(0, b[0].length, "Array in array"); We should test that /re/ regexp literals in arrays and objects perform as we expect and that. var n = new Object(); function make() { return [ n ]; } var a = make(); a[0].foo = "bar"; assertEquals("bar", n.foo) and similar cases. http://codereview.chromium.org/48006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
