http://codereview.chromium.org/48006/diff/1027/1033
File src/codegen-arm.cc (right):

http://codereview.chromium.org/48006/diff/1027/1033#newcode1
Line 1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
On 2009/03/20 09:09:36, Erik Corry wrote:
> 2009

Fixed a couple of places.

http://codereview.chromium.org/48006/diff/1027/1031
File src/runtime.cc (right):

http://codereview.chromium.org/48006/diff/1027/1031#newcode112
Line 112: if (copy->HasFastProperties()) {
On 2009/03/20 09:09:36, Erik Corry wrote:
> I think we can use Kasper's idea here to avoid the DescriptorReader
and just get
> the properties by their index from 0 to length - 1.

Let's do that in a later cl.

http://codereview.chromium.org/48006/diff/1027/1031#newcode129
Line 129: } else {
On 2009/03/20 09:09:36, Erik Corry wrote:
> It seems wrong that a boilerplate object should be non-fast case.
Lets submit
> this as it is then see if we can work out where the slow case maps are
coming
> from.  Ideally boilerplate objects should be all-in-object.

Ok

http://codereview.chromium.org/48006/diff/2054/2067
File src/objects.h (right):

http://codereview.chromium.org/48006/diff/2054/2067#newcode1401
Line 1401: // Access to set in object properties.
On 2009/03/20 09:09:36, Erik Corry wrote:
> ÷set

Fixed

http://codereview.chromium.org/48006

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to