LGTM other than a couple of style issues. While you're at it, you could make the loop in StoreToFrameSlotAt work the same way (just changing the index of all the copies, rather than resetting them). It's a little faster and a lot clearer.
http://codereview.chromium.org/47006/diff/1/2 File src/virtual-frame.cc (right): http://codereview.chromium.org/47006/diff/1/2#newcode393 Line 393: break; If the single-line body of an if statement is on a new line, surround it with braces. http://codereview.chromium.org/47006/diff/1/2#newcode406 Line 406: elements_[i] = CopyElementAt(frame_index); We might consider preserving the sync flag on elements_[i] (there is code in StoreToFrameSlot that tries to do that, but it looks like it doesn't even work for registers). http://codereview.chromium.org/47006/diff/1/2#newcode407 Line 407: for (int j = i+1; j < elements_.length(); j++) { Space around the binary operator. http://codereview.chromium.org/47006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
