http://codereview.chromium.org/47006/diff/1/2 File src/virtual-frame.cc (right):
http://codereview.chromium.org/47006/diff/1/2#newcode393 Line 393: break; On 2009/03/23 14:21:01, Kevin Millikin wrote: > If the single-line body of an if statement is on a new line, surround it with > braces. Done. http://codereview.chromium.org/47006/diff/1/2#newcode406 Line 406: elements_[i] = CopyElementAt(frame_index); On 2009/03/23 14:21:01, Kevin Millikin wrote: > We might consider preserving the sync flag on elements_[i] (there is code in > StoreToFrameSlot that tries to do that, but it looks like it doesn't even work > for registers). Done. http://codereview.chromium.org/47006/diff/1/2#newcode407 Line 407: for (int j = i+1; j < elements_.length(); j++) { On 2009/03/23 14:21:01, Kevin Millikin wrote: > Space around the binary operator. Done. http://codereview.chromium.org/47006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
