LGTM
http://codereview.chromium.org/53004/diff/28/1011 File src/heap.h (right): http://codereview.chromium.org/53004/diff/28/1011#newcode276 Line 276: #ifdef ENABLE_LOGGING_AND_PROFILING I'd like to hide behind a different ifdef for performance reasons. This one is on in released Chrome. http://codereview.chromium.org/53004/diff/28/1008 File src/platform-linux.cc (right): http://codereview.chromium.org/53004/diff/28/1008#newcode263 Line 263: void OS::Protect(void* address, size_t size) { This could call VirtualMemory::Protect or vice versa. http://codereview.chromium.org/53004/diff/28/1008#newcode464 Line 464: void VirtualMemory::Protect(void* address, size_t size) { Perhaps assert that we are aligned with page boundaries? http://codereview.chromium.org/53004/diff/28/1009 File src/platform-macos.cc (right): http://codereview.chromium.org/53004/diff/28/1009#newcode255 Line 255: not yet implemented? http://codereview.chromium.org/53004 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
