LGTM I also like the cleanup of parameter names etc.
http://codereview.chromium.org/53004/diff/31/1028 File src/log.cc (right): http://codereview.chromium.org/53004/diff/31/1028#newcode1128 Line 1128: // Are we leaving V8? ASSERT that previous state was not EXTERNAL and likewise for the other state changes to/from EXTERNAL. http://codereview.chromium.org/53004/diff/31/1026 File src/platform-linux.cc (right): http://codereview.chromium.org/53004/diff/31/1026#newcode256 Line 256: // TODO(1240712): munmap has a return value which is ignored here. Move this issue to code.google.com/p/v8. http://codereview.chromium.org/53004 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
