LGTM
http://codereview.chromium.org/42560/diff/1/3 File SConstruct (right): http://codereview.chromium.org/42560/diff/1/3#newcode390 Line 390: 'LIBPATH': [ANDROID_TOP + '/out/target/product/generic/obj/lib'], How about defining ANDROID_LINKFLAGS like ANDROID_FLAGS and ANDROID_INCLUDES? They look the same for shell sample and d8. http://codereview.chromium.org/42560 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
