Erik, I just noticed this androidification of our SConstruct that's been going on. So far we've made a very deliberate effort to make our build files as general as possible. For instance, rather than have special options for cross-compiling the build script we inherit CXX & co. from the environment. That way you can isolate the cross-compilation nastiness in a separate script and otherwise use the standard build process.
I'm sure that we can use the same approach for android, for instance by setting LINKFLAGS and co. in the environment. We may have to tweak the build scripts a little to make sure variables are inherited in the right way but I'll be happy to do that. People need to be able to compile v8 for new platforms without doing major surgery on our build scripts. If we can't do that ourselves then our build process is not flexible enough and that's something we will need to fix. -- Christian 2009/3/25 <[email protected]>: > > LGTM > > > http://codereview.chromium.org/42560/diff/1/3 > File SConstruct (right): > > http://codereview.chromium.org/42560/diff/1/3#newcode390 > Line 390: 'LIBPATH': [ANDROID_TOP + > '/out/target/product/generic/obj/lib'], > How about defining ANDROID_LINKFLAGS like ANDROID_FLAGS and > ANDROID_INCLUDES? They look the same for shell sample and d8. > > http://codereview.chromium.org/42560 > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
