Inlined RawSyncElementAt at call sites, optimized by hand.
http://codereview.chromium.org/49029/diff/1/2 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/49029/diff/1/2#newcode67 Line 67: break; // The current value on the stack is some safe value. On 2009/03/25 13:40:00, Kevin Millikin wrote: > I'd get rid of the comment. It's not clear what "safe" means (it's not safe for > space usage, for instance) and this is not the place to explain it anyway. Done. http://codereview.chromium.org/49029/diff/1/2#newcode70 Line 70: // There was an early bailout for synced elements On 2009/03/25 13:40:00, Kevin Millikin wrote: > Not an early bailout, it's a precondition (and you might consider to ASSERT that > !element.is_synced() to explicitly catch violations). Done. http://codereview.chromium.org/49029/diff/1/2#newcode123 Line 123: // There was an early bailout for invalid and synced elements On 2009/03/25 13:40:00, Kevin Millikin wrote: > Not an early bailout, but a precondition. In this case, it's impossible to have > memory elements (or any synced elements) above the stack pointer. Done. http://codereview.chromium.org/49029 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
