Oh, and LGTM.
http://codereview.chromium.org/49029/diff/2007/2010 File src/virtual-frame.cc (right): http://codereview.chromium.org/49029/diff/2007/2010#newcode216 Line 216: // [min(stack_pointer_,begin), end). You mean min(stack_pointer + 1, begin)? It might be better in the sense of avoiding surprise to not make this general and to require the caller to give a proper range (ie, beginning at or below stack_pointer + 1). It would be more explicit at the calling sites (both of them!) what's going on (and I think it's true now anyway). http://codereview.chromium.org/49029/diff/2007/2010#newcode220 Line 220: if (begin > stack_pointer_) { This whole think is just complicated enough to need some comments so it doesn't get off by one when maintaining it. http://codereview.chromium.org/49029 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
