LGTM Thanks for getting all this right.
http://codereview.chromium.org/53089/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/53089/diff/1/2#newcode2042 Line 2042: * a process. Perhaps explain in which cases this is actually necessary. http://codereview.chromium.org/53089/diff/1/5 File src/debug.cc (right): http://codereview.chromium.org/53089/diff/1/5#newcode1742 Line 1742: message_thread_->Stop(); Please add { }'s Why don't you have to delete message_thread_ here to avoid leaking? http://codereview.chromium.org/53089/diff/1/8 File src/flags.cc (right): http://codereview.chromium.org/53089/diff/1/8#newcode61 Line 61: bool owns_ptr_; Comment (or is it obvious)? http://codereview.chromium.org/53089/diff/1/18 File test/message/testcfg.py (right): http://codereview.chromium.org/53089/diff/1/18#newcode43 Line 43: Please add a comment on why these lines are ignored. http://codereview.chromium.org/53089 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
