Since this change, the shell sample can no longer be used interactively (the call to RunShell from main/RunMain was eliminated). Was that the intent?
2009/3/27 Christian Plesner Hansen <[email protected]> > > Sure am. > > On 3/27/09, Søren Gjesse <[email protected]> wrote: > > When you commit the CL is not updated with the revision of the actual > > commit. Are you not using gcl to commit? > > /Søren > > > > On Fri, Mar 27, 2009 at 01:24, <[email protected]> > wrote: > > > >> > >> http://codereview.chromium.org/53089/diff/1/2 > >> File include/v8.h (right): > >> > >> http://codereview.chromium.org/53089/diff/1/2#newcode2042 > >> Line 2042: * a process. > >> Done. I left it out originally because I had no idea what to write but > >> I've put something general. > >> > >> http://codereview.chromium.org/53089/diff/1/5 > >> File src/debug.cc (right): > >> > >> http://codereview.chromium.org/53089/diff/1/5#newcode1742 > >> Line 1742: message_thread_->Stop(); > >> Done. > >> > >> Technically it's not a leak as long as there's a static variable > >> pointing to it. But yes, it might as well be deleted. > >> > >> http://codereview.chromium.org/53089/diff/1/8 > >> File src/flags.cc (right): > >> > >> http://codereview.chromium.org/53089/diff/1/8#newcode61 > >> Line 61: bool owns_ptr_; > >> Done; it wasn't obvious. > >> > >> http://codereview.chromium.org/53089/diff/1/18 > >> File test/message/testcfg.py (right): > >> > >> http://codereview.chromium.org/53089/diff/1/18#newcode43 > >> Line 43: > >> Done > >> > >> > >> http://codereview.chromium.org/53089 > >> > > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
