I think this code should be cheap enough to always have it run, even in release. I will get back with some numbers on how much it speeds up valgrind, since we should now be able to safely run with --smc-check=none. I will also have to update the build files, etc.
On 2008/12/08 04:44:21, iposva wrote: > Dean, > In general I think the ability to use tools like valgrind is essential, but I > would strongly prefer a -DENABLE_VALGRIND flag to wrap the valgrind related > code. I do understand that it is hard to pass this down through the Chromium > build layers, but this is a feature that needs to be addressed at some time > anyway. In the meantime I would suggest you address this short-coming by setting > the macro in the scons file for the one platform where you care about valgrind > support, since currently two out of our three ia32-based platforms do not > support valgrind (Windows and Mac OS X). > Also you need to make sure that the license in the valgrind.h file is acceptable > for us to include it in src/third_party. > Cheers, > -Ivan http://codereview.chromium.org/13612 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
