ARM code generator has also been changed, to eliminate INC and DEC builtin.
http://codereview.chromium.org/56151/diff/1007/8 File src/codegen-ia32.cc (right): http://codereview.chromium.org/56151/diff/1007/8#newcode4699 Line 4699: bool target_size) On 2009/04/02 12:39:32, Kevin Millikin wrote: > How can this be a bool? Aren't the possible target sizes 0, 1, or 2? Done. http://codereview.chromium.org/56151/diff/1007/8#newcode4721 Line 4721: // Undo the optimistic smi increment. On 2009/04/02 12:39:32, Kevin Millikin wrote: > "smi increment or decrement"? "smi operation"? Done. http://codereview.chromium.org/56151/diff/1007/8#newcode4785 Line 4785: // old_value must be a register here, so that it is spilled by any call. On 2009/04/02 12:39:32, Kevin Millikin wrote: > This is confusing. It's not that we need it to be spilled by a call, it's that > it can't be a constant or copy because we (might) modify it and it's below the > water mark for the deferred code exit. > Since something weird is (intentionally) happening here we should be really > explicit about what it is: we are not allowed to modify constants and copies > below the water mark on deferred exit frames. Done. http://codereview.chromium.org/56151 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
