LGTM, but you should add a mjsunit test for at least the var x = "string"; x++ case.
You could also preemptively run the Webkit layout tests fast/js/codegen-temporaries and fast/js/constant-folding. http://codereview.chromium.org/56151/diff/1014/1015 File src/codegen-ia32.cc (right): http://codereview.chromium.org/56151/diff/1014/1015#newcode4759 Line 4759: // by a new register explicitly, to optimize the fast case. The comment about the new register seems out of place here. I'd get rid of it. http://codereview.chromium.org/56151 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
