LGTM!
http://codereview.chromium.org/67191/diff/1/4 File tools/codemap.js (right): http://codereview.chromium.org/67191/diff/1/4#newcode46 Line 46: * Deleted code entries. Please add "Used for JIT compiled code which has been garbage collected" to the comment. http://codereview.chromium.org/67191/diff/1/4#newcode199 Line 199: this.name = opt_name || ''; How about adding the empty name to the prototype: devtools.profiler.CodeMap.CodeEntry.prototype.name = ''; And than changing this assignament to: if (opt_name) { this.name = opt_name } http://codereview.chromium.org/67191 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
