http://codereview.chromium.org/67191/diff/1/4 File tools/codemap.js (right):
http://codereview.chromium.org/67191/diff/1/4#newcode46 Line 46: * Deleted code entries. On 2009/04/16 06:08:24, Søren Gjesse wrote: > Please add "Used for JIT compiled code which has been garbage collected" to the > comment. Done. http://codereview.chromium.org/67191/diff/1/4#newcode199 Line 199: this.name = opt_name || ''; On 2009/04/16 06:08:24, Søren Gjesse wrote: > How about adding the empty name to the prototype: > devtools.profiler.CodeMap.CodeEntry.prototype.name = ''; > And than changing this assignament to: > if (opt_name) { > this.name = opt_name > } I'll better not. First, this is the commonly used idiom for accessing optional parameters in JS. Second, it's 4 vs. 1 lines of code. http://codereview.chromium.org/67191 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
