LGTM Thank you for cleaning this up.
You will need to look at the tests in test-debug.cc though. http://codereview.chromium.org/67266/diff/1/2 File include/v8-debug.h (right): http://codereview.chromium.org/67266/diff/1/2#newcode81 Line 81: class Deletable { How about another name like ClientData or UserData, even though calling stuff XXXData is a bit awkward. Also add a comment saying that V8 will always delete this. http://codereview.chromium.org/67266/diff/1/2#newcode142 Line 142: static void SetMessageHandler(DebugMessageHandler handler, void* data = NULL, As discussed offline remove this data parameter. http://codereview.chromium.org/67266/diff/1/2#newcode148 Line 148: static void SetHostDispatchHandler(DebugHostDispatchHandler handler, Also get rid of this data parameter. http://codereview.chromium.org/67266 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
