* Addressed the comments * made necessary changes to the unit tests * fixed an issue with the queue expanding(it would dispose of its messages when expanding) * added 2 new unit tests for the queue expanding and client data handling
http://codereview.chromium.org/67266/diff/1/2 File include/v8-debug.h (right): http://codereview.chromium.org/67266/diff/1/2#newcode81 Line 81: class Deletable { On 2009/04/17 22:17:21, Søren Gjesse wrote: > How about another name like ClientData or UserData, even though calling stuff > XXXData is a bit awkward. Also add a comment saying that V8 will always delete > this. Done. Renamed to ClientData http://codereview.chromium.org/67266/diff/1/2#newcode142 Line 142: static void SetMessageHandler(DebugMessageHandler handler, void* data = NULL, On 2009/04/17 22:17:21, Søren Gjesse wrote: > As discussed offline remove this data parameter. Done. http://codereview.chromium.org/67266/diff/1/2#newcode148 Line 148: static void SetHostDispatchHandler(DebugHostDispatchHandler handler, On 2009/04/17 22:17:21, Søren Gjesse wrote: > Also get rid of this data parameter. Done. http://codereview.chromium.org/67266 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
