LGTM after addressing these comments. We should fix the xcode project and make sure to have a v8.gyp change ready for when this is pushed to chromium.
http://codereview.chromium.org/93066/diff/1/3 File src/arm/ic-arm.cc (left): http://codereview.chromium.org/93066/diff/1/3#oldcode280 Line 280: // Check that the value is a JSFunction. We need this JSFunction check. We invoke r1 below as a function, so we need to check that it is a function and otherwise go to the runtime system. That is the reason for not using GenerateCheckNonFunctionOrLoaded here. http://codereview.chromium.org/93066/diff/1/3 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/93066/diff/1/3#newcode140 Line 140: // Check if the function has been loaded. function -> object http://codereview.chromium.org/93066/diff/1/8 File src/handles.cc (right): http://codereview.chromium.org/93066/diff/1/8#newcode685 Line 685: // If lazy loading failed, restore the unloaded state of fun. fun -> obj http://codereview.chromium.org/93066/diff/1/9 File src/handles.h (right): http://codereview.chromium.org/93066/diff/1/9#newcode304 Line 304: void SetupLazy(Handle<JSObject> fun, fun -> object? http://codereview.chromium.org/93066/diff/1/9#newcode308 Line 308: void LoadLazy(Handle<JSObject> fun, bool* pending_exception); fun -> object? http://codereview.chromium.org/93066/diff/1/11 File src/ia32/ic-ia32.cc (left): http://codereview.chromium.org/93066/diff/1/11#oldcode491 Line 491: // Check that the value is a JavaScript function. You are removing a JSFunction check here - you shouldn't. The object will be invoked below, so it needs to be a function. http://codereview.chromium.org/93066/diff/1/12 File src/json-delay.js (right): http://codereview.chromium.org/93066/diff/1/12#newcode198 Line 198: member += " "; Indentation. http://codereview.chromium.org/93066/diff/1/18 File src/objects.h (right): http://codereview.chromium.org/93066/diff/1/18#newcode2586 Line 2586: // But positions for but field 2 Bit positions for bit field 2? http://codereview.chromium.org/93066 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
