No comment means "fixed".
http://codereview.chromium.org/93066/diff/1/3 File src/arm/ic-arm.cc (left): http://codereview.chromium.org/93066/diff/1/3#oldcode280 Line 280: // Check that the value is a JSFunction. Oh, good point. http://codereview.chromium.org/93066/diff/1/12 File src/json-delay.js (right): http://codereview.chromium.org/93066/diff/1/12#newcode40 Line 40: // include them in the reg exps in all places where whitespace is allowed. Good point. http://codereview.chromium.org/93066/diff/1/12#newcode57 Line 57: return global.eval('(' + s + ')'); That's not the reason I'm adding it but more to have JSON available without having to send the code over the wire. I didn't have any plans to change this. I'll submit the code as it is and then I'll take a look at how difficult it would be to move the critical parts into the vm. It might just be a matter of adding a special flavor of global eval that has an extra check that the AST is benign before executing it that bails out if it isn't. http://codereview.chromium.org/93066/diff/1/12#newcode165 Line 165: indent = stepback; Good point. I was following the spec a bit too closely. http://codereview.chromium.org/93066/diff/1/12#newcode179 Line 179: if (ObjectHasOwnProperty.call(replacer, i)) { I got ascending and descending mixed up. Even though what I have is called "right/left confusion" it actually means that I confuse any pair of directions, as this demonstrates. Also good and evil. http://codereview.chromium.org/93066/diff/1/12#newcode185 Line 185: member += " "; Gah. But you're right. http://codereview.chromium.org/93066/diff/1/18 File src/objects.h (right): http://codereview.chromium.org/93066/diff/1/18#newcode2586 Line 2586: // But positions for but field 2 Whoops. http://codereview.chromium.org/93066 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
