I don't like the idea that some events results in the VM being stopped
(break and exception) and others (afterCompile) that it keeps running.
For the synchronous listener all events per definition caused the VM to
stop until you returned.

However the event/response JSON have the running property which indicate
whether the VM is running or not. If you can set that to true for the
afterCompile event there is a way to determine the running state of the
VM.



http://codereview.chromium.org/100034/diff/10/1006
File src/debug.cc (right):

http://codereview.chromium.org/100034/diff/10/1006#newcode1802
Line 1802: CHECK(Debug::InDebugger());
Please use ASSERT.

http://codereview.chromium.org/100034/diff/10/1005
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/100034/diff/10/1005#newcode3493
Line 3493: // beforeCompile event).
beforeCompile -> afterCompile right?

http://codereview.chromium.org/100034/diff/10/1005#newcode3497
Line 3497: // is empty on beforeCompile event.
beforeCompile -> afterCompile right?

http://codereview.chromium.org/100034/diff/10/1005#newcode3657
Line 3657: // All the messages will be processed on beforeCompile event.
beforeCompile -> afterCompile right?

http://codereview.chromium.org/100034

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to