Addressed all comments. The running property is true for the copile events.
http://codereview.chromium.org/100034/diff/10/1006 File src/debug.cc (right): http://codereview.chromium.org/100034/diff/10/1006#newcode1802 Line 1802: CHECK(Debug::InDebugger()); On 2009/04/27 11:00:05, Søren Gjesse wrote: > Please use ASSERT. Done. http://codereview.chromium.org/100034/diff/10/1005 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/100034/diff/10/1005#newcode3493 Line 3493: // beforeCompile event). On 2009/04/27 11:00:05, Søren Gjesse wrote: > beforeCompile -> afterCompile right? No, beforeCompile will happen first and it will trigger message handling. http://codereview.chromium.org/100034/diff/10/1005#newcode3497 Line 3497: // is empty on beforeCompile event. On 2009/04/27 11:00:05, Søren Gjesse wrote: > beforeCompile -> afterCompile right? See my comment above. http://codereview.chromium.org/100034/diff/10/1005#newcode3657 Line 3657: // All the messages will be processed on beforeCompile event. On 2009/04/27 11:00:05, Søren Gjesse wrote: > beforeCompile -> afterCompile right? See my comment above. http://codereview.chromium.org/100034 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
