LGTM Could you please add the new files as well? You can just add empty files at first that just contain the copyright notice.
http://codereview.chromium.org/99186/diff/1/2 File SConstruct (right): http://codereview.chromium.org/99186/diff/1/2#newcode155 Line 155: }, Is this comma needed? http://codereview.chromium.org/99186/diff/1/2#newcode557 Line 557: }, comma needed? http://codereview.chromium.org/99186/diff/1/3 File src/SConscript (right): http://codereview.chromium.org/99186/diff/1/3#newcode78 Line 78: # 'x64/regexp-macro-assembler-x64.cc', Since none of the files exist yet anyway, why is this one commented out? http://codereview.chromium.org/99186/diff/1/4 File src/codegen.h (right): http://codereview.chromium.org/99186/diff/1/4#newcode79 Line 79: #ifdef V8_ARCH_ARM You need to update the other build systems as well in order not to break builds. You need to make sure that V8_ARCH_ARM is defined instead of ARM. You need to do this in visual studio project, xcode project and the v8.gyp file. http://codereview.chromium.org/99186/diff/1/6 File src/frames-inl.h (right): http://codereview.chromium.org/99186/diff/1/6#newcode37 Line 37: #include "ia64/frames-ia64.h" ia64 / x64 confusion. http://codereview.chromium.org/99186/diff/1/11 File src/platform-freebsd.cc (right): http://codereview.chromium.org/99186/diff/1/11#newcode174 Line 174: #ifdef (defined(__arm__) || defined(__thumb__)) Should this just be an #if? http://codereview.chromium.org/99186 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
