Addressed comments.
http://codereview.chromium.org/99186/diff/1/2 File SConstruct (right): http://codereview.chromium.org/99186/diff/1/2#newcode155 Line 155: }, Not needed. I would prefer to have it everywhere (makes reordering much easier), but since it's not the style, I should go for consistency instead. http://codereview.chromium.org/99186/diff/1/3 File src/SConscript (right): http://codereview.chromium.org/99186/diff/1/3#newcode78 Line 78: # 'x64/regexp-macro-assembler-x64.cc', Because we can actually do without it. The test for whether to use native or interpreted regexp is set to use the interpreter (like on ARM). http://codereview.chromium.org/99186/diff/1/4 File src/codegen.h (right): http://codereview.chromium.org/99186/diff/1/4#newcode79 Line 79: #ifdef V8_ARCH_ARM Attempted done. No guarantees on the XCode project file. It's not made for hand editing. http://codereview.chromium.org/99186/diff/1/6 File src/frames-inl.h (right): http://codereview.chromium.org/99186/diff/1/6#newcode37 Line 37: #include "ia64/frames-ia64.h" Yes, my bad. http://codereview.chromium.org/99186/diff/1/11 File src/platform-freebsd.cc (right): http://codereview.chromium.org/99186/diff/1/11#newcode174 Line 174: #ifdef (defined(__arm__) || defined(__thumb__)) Fixed. http://codereview.chromium.org/99186 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
