Reviewers: Mads Ager, Message: This should make the scons build work on Windows as well. (Silly me only tested building from VS)
Description: Added architecture properties to Windows Scons build. Made scons build work on windows. Please review this at http://codereview.chromium.org/100175 Affected files: M SConstruct Index: SConstruct diff --git a/SConstruct b/SConstruct index 4365aa8a169d0676e253fc6d6090bfec2e1c653a..9842e928fbe81d1c6592d47f52afa50b2d4f8d39 100644 --- a/SConstruct +++ b/SConstruct @@ -172,6 +172,9 @@ LIBRARY_FLAGS = { 'ARFLAGS': ['/NOLOGO'], 'CCPDBFLAGS': ['/Zi'] }, + 'arch:ia32': { + 'CPPDEFINES': ['V8_ARCH_IA32'] + }, 'mode:debug': { 'CCFLAGS': ['/Od', '/Gm'], 'CPPDEFINES': ['_DEBUG', 'ENABLE_DISASSEMBLER', 'DEBUG'], @@ -234,7 +237,7 @@ V8_EXTRA_FLAGS = { 'LIBS': ['winmm', 'ws2_32'] }, 'arch:arm': { - 'CPPDEFINES': ['ARM'], + 'CPPDEFINES': ['ARM', 'V8_ARCH_ARM'], # /wd4996 is to silence the warning about sscanf # used by the arm simulator. 'WARNINGFLAGS': ['/wd4996'] @@ -341,6 +344,9 @@ CCTEST_EXTRA_FLAGS = { }, 'library:shared': { 'CPPDEFINES': ['USING_V8_SHARED'] + }, + 'arch:ia32': { + 'CPPDEFINES': ['V8_ARCH_IA32'] } } } @@ -433,6 +439,9 @@ SAMPLE_FLAGS = { 'LINKFLAGS': ['/LTCG'], } }, + 'arch:ia32': { + 'CPPDEFINES': ['V8_ARCH_IA32'] + }, 'mode:debug': { 'CCFLAGS': ['/Od'], 'LINKFLAGS': ['/DEBUG'], --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
